Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate More Helpful Logs On Package Validation Failure #555

Open
GfEW opened this issue Jan 9, 2024 · 0 comments
Open

Generate More Helpful Logs On Package Validation Failure #555

GfEW opened this issue Jan 9, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@GfEW
Copy link

GfEW commented Jan 9, 2024

TLDR
Tackling validation failures would profit a lot from Neo Store making use of proper error logging, providing easily searchable, comprehensible information on the failure.

When trying to update Cromite to v120.0.6099.199, the update downloads up to 100%, but then fails with the error notification Could not validate Cromite. Could not check integrity. I've emptied the cache of Neo Store, as well as restarted the app, to no avail.

Because no other of the other 20+ updates currently listed in my instance of Neo Store fail validation, and I've been able to update Cromite in Neo Store before, I have already filed a Cromite issue.

However, Neo Store's handling of this type of error leaves room for improvement.

I've searched App Manager's log viewer for various terms like "validat", "integr", "verif" or "cromi", to only find a few informatory entries about the ongoing package download or the processing NeoStore's notification, with no reference to the actual validation failure whatsoever.

Please, consider to log the affected package's name, download path and correct/failing key or checksum, it would make understanding the actual issue at hand much easier.

Am I missing something - is there a better place to look for the details, or are there different log search terms that would reveal more useful information? If so, please provide a suitable link somewhere in Neo Store's prefs.

Update 2024-01-11 20:16
Curiously enough, the update has succeeded by now (roughly on the 6th try, 30 h after first failure), before the maintainer of Cromite actually fixed anything. I haven't done anything I hadn't already done in the course of the repeatedly failing attempts, either. Ideas what's going on, anyone?

Side note:
I'm not entirely sure where this "lack of error logging" originates and should be reported; Neo Store just seems to be the most likely candidate. Should it rather be some other app's fault, please let me know and feel free to close it here.

@GfEW GfEW changed the title On validation failure, Neo Store should generate more helpful log entries Generate More Helpful Log Entries On Pachage Validation Failure Jan 11, 2024
@GfEW GfEW changed the title Generate More Helpful Log Entries On Pachage Validation Failure Generate More Helpful Log Entries On Package Validation Failure Jan 11, 2024
@GfEW GfEW changed the title Generate More Helpful Log Entries On Package Validation Failure Generate More Helpful Logs On Package Validation Failure Feb 26, 2024
@machiav3lli machiav3lli added the enhancement New feature or request label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants