Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onConfirmSignup accepts null for success whereas onLogin, onSignUp accepts empty string for success #444

Open
tushxr16 opened this issue Aug 23, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@tushxr16
Copy link

Describe the bug
To maintain consistency with the existing functions which accept empty string as a measure of success, the onConfirmSignup should also follow the same behavior.

To Reproduce
Steps to reproduce the behavior:

  1. Go to FlutterLogin( onConfirmSignup: (String code, LoginData data) => _onConfirmSignup(context, code, data) )
  2. onConfirmSignup code should be like this to maintain consistency with other functions
    Future<String> _onConfirmSignup( BuildContext context, String code, LoginData data) async { // logic return ''; }
  3. Instead we have to in following way
    Future<String?> _onConfirmSignup( BuildContext context, String code, LoginData data) async { // logic return null; }
@tushxr16 tushxr16 added the bug Something isn't working label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant