Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why isn't TimetabledPassingTime ordered? #692

Open
skinkie opened this issue Mar 22, 2024 · 3 comments
Open

Why isn't TimetabledPassingTime ordered? #692

skinkie opened this issue Mar 22, 2024 · 3 comments
Assignees
Milestone

Comments

@skinkie
Copy link
Contributor

skinkie commented Mar 22, 2024

StopPointInJourneyPattern is an embedded object which is ordered. What is the reason that TimetabledPassingTime wasn't made ordered?

@Aurige
Copy link
Contributor

Aurige commented Mar 25, 2024

The TimetabledPassingTime is directly linked to a StopPointInJourneyPattern (or more generally PointInJourneyPattern ) and therefore benefit directly from its order (therefore addind an order would mainly be a source of unconsistency)

image

image

@skinkie
Copy link
Contributor Author

skinkie commented Mar 25, 2024

The TimetabledPassingTime is directly linked to a StopPointInJourneyPattern (or more generally PointInJourneyPattern ) and therefore benefit directly from its order (therefore addind an order would mainly be a source of unconsistency)

While it benefits from a foreign order, only after it has been related, I noticed something cool happening on StopPointInJourneyPattern, being that it can take the same id of the ServiceJourneyPattern, and the order makes the StopPointInJourneyPattern (and others) unique. I think having passingTimings with the id of the parent, and the order to make the passing time unique, could certainly bring some elegance.

@Aurige
Copy link
Contributor

Aurige commented Apr 15, 2024

Should we discuss this as a possible EPIP recommendation ?

@ue71603 ue71603 added the EPIP label Apr 17, 2024
@ue71603 ue71603 added this to the netex_2.0 milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants