Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SAR Speedrun Timer #1

Open
JaioCG opened this issue Dec 4, 2023 · 1 comment
Open

Support SAR Speedrun Timer #1

JaioCG opened this issue Dec 4, 2023 · 1 comment

Comments

@JaioCG
Copy link

JaioCG commented Dec 4, 2023

Currently only sar_timer_[start/stop] is supported, which is deprecated and not used by categories/mtriggers. Instead, sar_speedrun timer should be used for speedrun timing instead.

Currently in sdp, the SAR timer module checks for the commands sar_timer_[start/stop], simply changing these to be the speedrun timer won't work since those aren't manually ran, but instead are automatically checked, and the SpeedrunTimer::Start() function runs in SAR. Not really sure the best way about fixing this.

@NeKzor
Copy link
Owner

NeKzor commented Mar 30, 2024

This will take a while because I noticed a lot of issues when porting the library to TypeScript which I want to fix in 1.0. It will most likely be introduced as SarSpeedrunTimer in a separate module. Reusing the code that is used from the autorender project is probably a good start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants