Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly set X-Partial-Results #879

Closed
ivakegg opened this issue Jul 31, 2020 · 1 comment · May be fixed by #2348
Closed

Correctly set X-Partial-Results #879

ivakegg opened this issue Jul 31, 2020 · 1 comment · May be fixed by #2348
Assignees
@plainolneesh

Comments

@ivakegg
Copy link
Collaborator

ivakegg commented Jul 31, 2020

X-Partial-Results and PartialResults in the response should indicate whether we are returning less than the requested page size in a response.
@plainolneesh plainolneesh self-assigned this Apr 6, 2021
plainolneesh added a commit to plainolneesh/datawave that referenced this issue May 11, 2021
@plainolneesh
Re: NationalSecurityAgency#879 Indicate whether we ar returning less …
b1498b3 
…than the requested page size
plainolneesh added a commit to plainolneesh/datawave that referenced this issue May 13, 2021
@plainolneesh
Re: NationalSecurityAgency#879 Indicate whether we ar returning less …
918247f 
…than the requested page size, corrected spelling
@billoley
Copy link
Collaborator

Just took a look at the related PR. Is there any more information on when X-Partial-Results isn't getting correctly set on the response? It seems that the logic is in place in RunningQuery, AbstractQueryLogicTransformer, and ResponseInterceptor.

plainolneesh added a commit to plainolneesh/datawave that referenced this issue Jun 2, 2021
@plainolneesh
Re:NationalSecurityAgency#879 - Removed trigger booleans, is page les…
85c6110 
…s than requested page size, update status
plainolneesh added a commit to plainolneesh/datawave that referenced this issue Jun 2, 2021
@plainolneesh
Re:NationalSecurityAgency#879 - Removed trigger booleans, is page les…
7bd9ac2 
…s than requested page size, update status
plainolneesh added a commit to plainolneesh/datawave that referenced this issue Jun 2, 2021
@plainolneesh
Re:NationalSecurityAgency#879 - Removed trigger booleans, is page les…
e7c9771 
…s than requested page size, update status
@plainolneesh plainolneesh mentioned this issue Jun 2, 2021
Merged
ivakegg pushed a commit that referenced this issue Nov 9, 2021
@plainolneesh
Fixes #879 - X-Partial Status (#1195)
3b999e3 
* Re:#897 - Removed trigger booleans, is page less than requested page size, update status
@foster33 foster33 mentioned this issue Apr 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plainolneesh plainolneesh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly set X-Partial-Results NationalSecurityAgency/datawave
3 participants
@ivakegg @plainolneesh @billoley