Cleanup/consolidate QueryExecutorBean's Persister usage #2308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-ratcliffe
force-pushed
the
issue/2307
branch
2 times, most recently
from
f4eeddc
to
85c57ad
Compare
keith-ratcliffe
force-pushed
the
issue/2307
branch
from
85c57ad
to
af421c6
Compare
MiguelRicardos
approved these changes
Mar 18, 2024
MiguelRicardos
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #2251 (#2252)...
#2252 fixed a bug related to max results override validation by leveraging
QueryLogic.getResultLimitin QEB's validateQuery methodThat is,
getResultLimittakes into account all configured overrides (e.g., QueryLogic, DN, and systemFrom overrides), which is necessary to properly validate the user's ownmax.results.overrideparameter.Unfortunately, that fix created even more unnecessary duplication of
Queryinitialization logic in QEB....logic that I lifted fromPersister.create, and logic that was already duplicated in several spots in QEB.So, this PR attempts to consolidate all of that into
validateQuery, extending theQueryDataclass to encapsulate the Query instance(The diff is a lot easier to read with whitespace ignored)