New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to summarize counts for DiscoveryLogic #2298
Open
lbschanno
wants to merge
10
commits into
integration
Choose a base branch
from
discoveryLogicSummary
base: integration
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the query parameter sum.counts that, when specified for the DiscoveryLogic, will results in counts being summed up across the specified time range, rather than returning counts per day. Closes #2222
ivakegg
reviewed
Mar 13, 2024
warehouse/query-core/src/test/java/datawave/query/discovery/DiscoveryLogicTest.java
Outdated
Show resolved
Hide resolved
ivakegg
reviewed
Mar 13, 2024
warehouse/query-core/src/test/java/datawave/query/discovery/DiscoveryLogicTest.java
Outdated
Show resolved
Hide resolved
ivakegg
reviewed
Mar 13, 2024
warehouse/query-core/src/test/java/datawave/query/discovery/DiscoveryLogicTest.java
Show resolved
Hide resolved
avgAGB
reviewed
Apr 12, 2024
warehouse/query-core/src/main/java/datawave/query/discovery/DiscoveryIterator.java
Outdated
Show resolved
Hide resolved
avgAGB
approved these changes
Apr 16, 2024
ivakegg
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the query parameter
sum.counts
that, given a value oftrue
for the DiscoveryLogic, will results in counts being summed up across the specified time range, rather than returning counts per day. This will result in blank dates being returned for eachDiscoveredThing
.Closes #2222