Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examine EventMetadata frequency flag validity #2076

Open
lbschanno opened this issue Aug 28, 2023 · 0 comments
Open

Examine EventMetadata frequency flag validity #2076

lbschanno opened this issue Aug 28, 2023 · 0 comments
Assignees

Comments

@lbschanno
Copy link
Collaborator

lbschanno commented Aug 28, 2023

EventMetadata accepts the boolean flag frequency both in its constructor, and as an argument to its various overloaded addEvent() methods. When a value of false is passed into the constructor, 'f' rows will not be written to the metadata table. When a value of false is passed into one of the addEvent() methods, the event information will not be added to the tracked frequency counts that can later be written to 'f' rows.

Given that 'f' rows should always be written, we should consider removing the option to disable writing 'f' rows, or discuss if this flag is actually intended to control whether 'tf' rows are written. The latter consideration originates from the fact that the value passed into EventMetadata's constructor ultimately comes from the configuration properties error.metadata.term.frequency.enabled and metadata.term.frequency.enabled.

@mineralntl mineralntl self-assigned this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants