Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JEXL3: Look into JEXL's updated 'contains' support #2002

Open
jwomeara opened this issue Jun 16, 2023 · 3 comments
Open

JEXL3: Look into JEXL's updated 'contains' support #2002

jwomeara opened this issue Jun 16, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@jwomeara
Copy link
Collaborator

JEXL updated the default arithmetic to support comparisons against sets of values. We should look into this and see if it is suitable for our needs. If so, we might be able to remove our custom functional set logic.

@jwomeara jwomeara added the enhancement New feature or request label Jun 16, 2023
@cogross cogross self-assigned this Jan 3, 2024
@cogross
Copy link
Collaborator

cogross commented Jan 16, 2024

Was fighting with getting everything rewired to use JEXL3.3 instead of 2.1.1. Saw that a new jexl3 branch popped in. Running from that, I have determined that DelegatingArithmetic.contains() and EdgePreconditionArithmetic.contains() can be removed.
I can make a branch based off jexl3 and remove those 2 functions, or it could just be a part of the new branch. Thoughts?

@jwomeara
Copy link
Collaborator Author

We don't want to remove contains. The ticket is to move away from our functional set usage and rely on contains instead. This work shouldn't be done at all until the jexl3 branch is merged, so I would direct all of your comments there in the form of a review.

@cogross
Copy link
Collaborator

cogross commented Jan 16, 2024

Okay. Wasn't sure which set comparisons to use then. I'll look over that branch when it's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants