diff --git a/packages/shared/lib/services/sync/data/data.service.ts b/packages/shared/lib/services/sync/data/data.service.ts index 79d99ed223..fdc4366417 100644 --- a/packages/shared/lib/services/sync/data/data.service.ts +++ b/packages/shared/lib/services/sync/data/data.service.ts @@ -35,13 +35,18 @@ export async function upsert( try { const encryptedRecords = encryptionManager.encryptDataRecords(recordsWithoutDuplicates); - await schema().from(RECORDS_TABLE).insert(encryptedRecords).onConflict(['nango_connection_id', 'external_id', 'model']).merge(); + const externalIds = await schema() + .from(RECORDS_TABLE) + .insert(encryptedRecords) + .onConflict(['nango_connection_id', 'external_id', 'model']) + .merge() + .returning('external_id'); if (softDelete) { return { success: true, summary: { - deletedKeys: [...addedKeys, ...updatedKeys], + deletedKeys: externalIds.map(({ external_id }) => external_id), addedKeys: [], updatedKeys: [] } diff --git a/packages/shared/lib/services/sync/run.service.integration.test.ts b/packages/shared/lib/services/sync/run.service.integration.test.ts index 162d47f280..ea9bf96f9e 100644 --- a/packages/shared/lib/services/sync/run.service.integration.test.ts +++ b/packages/shared/lib/services/sync/run.service.integration.test.ts @@ -164,7 +164,7 @@ describe('Running sync', () => { { id: '1', name: 'a' }, { id: '2', name: 'b' } ]; - const expectedResult = { added: 0, updated: 0, deleted: 0 }; + const expectedResult = { added: 0, updated: 0, deleted: 2 }; const { records } = await verifySyncRun(rawRecords, rawRecords, false, expectedResult, softDelete); expect(records).lengthOf(2); records.forEach((record) => {