Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong static_assert for function that should be a unique_function. #25

Open
atomgalaxy opened this issue Mar 27, 2019 · 1 comment
Open
Labels

Comments

@atomgalaxy
Copy link

@Naios


Commit Hash

e3695b4

Expected Behavior

When trying to make a fu2::function with a move-only object, you get an assert_error with the message "Can't wrap a non copyable object into a fu2::function, try using fu2::unique_function instead."

Actual Behavior

You get an error with "Can't wrap a non copyable object into a unique function!", which is super confusing.

Code at https://github.com/Naios/function2/blob/master/include/function2/function2.hpp#L1262

@Naios
Copy link
Owner

Naios commented Mar 27, 2019

Yes, you are right, the assertion message is misleading indeed.
Could you open a pull request with a message which would fit best in your opinion?

@Naios Naios added minor and removed enhancement labels Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants