Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop dumping the store when viewing different profiles; fix ID issue #711

Open
allthesignals opened this issue Apr 18, 2019 · 1 comment
Open

Stop dumping the store when viewing different profiles; fix ID issue #711

allthesignals opened this issue Apr 18, 2019 · 1 comment

Comments

@allthesignals
Copy link
Collaborator

See "downloadable" mixin:

There are duplicates because id is based arbitrarily on the array index.

does this mean that if we had different IDs, we could cache all the profiles for a given session and not have to redownload when selecting back & forth btwn multiple profiles? we should add this to a todo ticket :)

Originally posted by @julialucyhogan in #710
@allthesignals allthesignals mentioned this issue Apr 18, 2019
Merged
@allthesignals allthesignals changed the title Stop dumping the store on profile changes; fix ID issue Stop dumping the store when viewing different profiles; fix ID issue Apr 18, 2019
@allthesignals
Copy link
Collaborator Author

https://github.com/NYCPlanning/labs-factfinder/blob/develop/app/mixins/downloadable.js#L22

Not sure why this is an issue anymore. Is there a race condition?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@allthesignals