Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demapper: NaN LLR values output for high SNR inputs. #326

Closed
japm48 opened this issue Feb 4, 2024 · 2 comments
Closed

demapper: NaN LLR values output for high SNR inputs. #326

japm48 opened this issue Feb 4, 2024 · 2 comments

Comments

@japm48
Copy link
Contributor

japm48 commented Feb 4, 2024

Simple example to reproduce this: https://gist.github.com/japm48/41bc963efec39e506c17e419c3d1e13f

Basically, the demapper outputs NaN values when the SNR is too low, this can be seen that by reducing ebno_db this issue goes away.

The cause seems to be on the Demapper, where the exponents -squared_dist/no_eff passed to SymbolLogits2LLRs become -∞.

I'll create a PR with a simple fix.

Aside from that, I think that the "distance to all symbols" technique is computationally suboptimal in many common cases, e.g. on uniformly-distributed QPSK with Gray coding the exact LLRs should be proportional to the real and imag parts, no log nor exp needed (I will open a separate issue addressing this).

@SebastianCa
Copy link
Collaborator

Hi,
thanks for reporting this issue. We can reproduce the issue and will look into it.

@SebastianCa
Copy link
Collaborator

Fixed in Sionna v0.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants