Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple intrinsics and different image sizes #64

Open
pooncs opened this issue Oct 24, 2022 · 1 comment
Open

Support for multiple intrinsics and different image sizes #64

pooncs opened this issue Oct 24, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@pooncs
Copy link

pooncs commented Oct 24, 2022

Hi I am coming from Instant-ngp, and lately, they added the capability to load individual intrinsics (by moving the global intrinsics in the json to each image). This also allows for loading different size images (or rotated images). I was wondering if there is any plans to add this capability? Thanks.

@orperel
Copy link
Collaborator

orperel commented Oct 27, 2022

Hi @pooncs,
Thanks for your interest!
Since we're currently preoccupied with other tasks, I could guide you how to do it if you wish to do so.

Variable-sized images and custom intrinsics can be supported by adding a new type of pytorch dataset, similar to how the MultiviewDataset was created (see:

class MultiviewDataset(Dataset):
):

  1. Create a MultiviewIntrinsicsDataset class. You can use MultiviewDataset as a reference.
  2. Have a look at nerf_standard.py - you want to update this logic (
    def load_nerf_standard_data(root, split='train', bg_color='white', num_workers=-1, mip=None):
    ).
  1. In the new MultiviewIntrinsicsDataset class, invoke your updated logic and again take care not to break due to stacking images together (the assumption in MultiviewDataset no longer holds).

If you post a MR, I can help quickly review and integrate it (we could also replace the current logic if the performance penalty is negligible).

@orperel orperel added the enhancement New feature or request label Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants