Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Issues found by Spark UT Framework on RapidsJsonSuite #10773

Open
10 of 13 tasks
binmahone opened this issue May 7, 2024 · 0 comments
Open
10 of 13 tasks

[BUG] Issues found by Spark UT Framework on RapidsJsonSuite #10773

binmahone opened this issue May 7, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@binmahone
Copy link
Collaborator

binmahone commented May 7, 2024

Describe the bug

Spark UT Framework enabled RapidsJsonSuite (#10743), with the following test cases explicitly excluded:

These excluded test cases needs further investigating!!!
Notice: Other test cases in this suite may pass with falling back!

Steps/Code to reproduce bug

  1. Compile everything with mvn -Dbuildver=330 install -DskipTests
  2. Pick a test case name in the above table
  3. Go to RapidsTestSettings and find the line starting with ".exclude" and containing the test case name, comment it out
  4. Run the Suite then you'll see one failed test case. E.g. mvn -nsu -Dbuildver=330 -pl tests -Dsuites="org.apache.spark.sql.rapids.suites.RapidsXXXSuite" test (replace RapidsXXXSuite with the right name in issue header). ALWAYS double check if your suite name coincide with in source code, as it may contain typos!

Expected behavior
The suite can pass without excluding any test case.

@binmahone binmahone added bug Something isn't working ? - Needs Triage Need team to review and classify labels May 7, 2024
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label May 7, 2024
gerashegalov added a commit to gerashegalov/spark-rapids that referenced this issue May 29, 2024
Closes NVIDIA#10875
Contributes to NVIDIA#10773

Spark UTs need to be able to spark.read data

Signed-off-by: Gera Shegalov <gera@apache.org>
gerashegalov added a commit that referenced this issue May 30, 2024
Closes #10875
Contributes to #10773
    
Unjar, cache, and share the test jar content among all test suites from the same jar

Test:
```bash
mvn package -Dbuildver=330 -pl tests -am -Dsuffixes='.*\.RapidsJsonSuite'
```

Signed-off-by: Gera Shegalov <gera@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants