Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Issues found by Spark UT Framework on RapidsCastSuite #10771

Open
7 tasks
binmahone opened this issue May 7, 2024 · 1 comment
Open
7 tasks

[BUG] Issues found by Spark UT Framework on RapidsCastSuite #10771

binmahone opened this issue May 7, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@binmahone
Copy link
Collaborator

binmahone commented May 7, 2024

Describe the bug

Spark UT Framework enabled RapidsCastSuite (#10743), with the following test cases explicitly excluded:

  • [BUG] Incorrect cast of string columns containing various infinity notations with trailing spaces  #10794
    Break UT "Process Infinity, -Infinity, NaN in case insensitive manner"
  • cast string "1582-10-15 23:59:59.0" not correct to "1582-10-15 18:09:39.0".
    Break UT: "cast timestamp without time zone to timestamp with local time zone"
  • cast "0001-01-01 05:50:20" as timestamp_ntz not correct to "0001-01-01T05:50:20"
    Break UT: "cast timestamp with local time zone to timestamp without timezone"
  • string being cast to a day-time interval does not have a valid format, or out of acceptable range or overflow issue.
    Break UT "Cast string to day-time interval"
  • string format provided for the cast operation was invalid.
    Break UT: "Take into account day-time interval fields in cast"
  • [BUG] cast(9.95 as decimal(3,1)), actual: 9.9, expected: 10.0 #10809
    Break UT "casting to fixed-precision decimals"
  • IExampleBaseType is not presumably a user-defined type, not annotated with @SQLUserDefinedType or registed with UDTRegistration.
    Break UT "cast from a derived user-defined type to a base type"

These excluded test cases needs further investigating!!!
Notice: Other test cases in this suite may pass with falling back!

Steps/Code to reproduce bug

  1. Compile everything with mvn -Dbuildver=330 install -DskipTests
  2. Pick a test case name in the above table
  3. Go to RapidsTestSettings and find the line starting with ".exclude" and containing the test case name, comment it out
  4. Run the Suite then you'll see one failed test case. E.g. mvn -nsu -Dbuildver=330 -pl tests -Dsuites="org.apache.spark.sql.rapids.suites.RapidsXXXSuite" test (replace RapidsXXXSuite with the right name in issue header). ALWAYS double check if your suite name coincide with in source code, as it may contain typos!

Expected behavior
The suite can pass without excluding any test case.

@binmahone binmahone added bug Something isn't working ? - Needs Triage Need team to review and classify labels May 7, 2024
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label May 7, 2024
@mattahrens
Copy link
Collaborator

Initial scope is triaging unit test failures to determine priorities of individual issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants