Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] GpuTimeZoneDB missed some time zones which are not normalized. #1721

Open
res-life opened this issue Jan 24, 2024 · 2 comments
Open

[BUG] GpuTimeZoneDB missed some time zones which are not normalized. #1721

res-life opened this issue Jan 24, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@res-life
Copy link
Collaborator

Describe the bug
GpuTimeZoneDB only index normalized time zones, but the original time zone names are ignored, user can use original time zone.

Steps/Code to reproduce bug

import java.util._
import java.time._
val ids = TimeZone.getAvailableIDs.map(e => ZoneId.of(e, ZoneId.SHORT_IDS).normalized.getId)
val ids2 = TimeZone.getAvailableIDs

for (id <- ids2) {
    if (!ids.contains(id)) {
        println("In normalized, but missed in general: " + id)
    }
}

Spark:
>>> spark.sql("select cast('1970-01-01 00:00:00 Etc/GMT' as timestamp)").show()
+----------------------------------------------+
|CAST(1970-01-01 00:00:00 Etc/GMT AS TIMESTAMP)|
+----------------------------------------------+
|                           1970-01-01 08:00:00|
+----------------------------------------------+
In normalized, but missed in general: Etc/GMT
In normalized, but missed in general: Etc/GMT+0
In normalized, but missed in general: Etc/GMT+1

@res-life res-life added bug Something isn't working ? - Needs Triage labels Jan 24, 2024
@res-life
Copy link
Collaborator Author

We should pass map into kernel.

@res-life
Copy link
Collaborator Author

I'm not planing work on this for release 24.04
@sameerz can we move it to next release?

@res-life res-life removed their assignment Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants