Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Lint Checks for Checking Code Style #1656

Open
razajafri opened this issue Dec 15, 2023 · 2 comments
Open

Introduce Lint Checks for Checking Code Style #1656

razajafri opened this issue Dec 15, 2023 · 2 comments
Assignees

Comments

@razajafri
Copy link
Collaborator

We should introduce lint checks that prevent files with format problems like line-length checks as was caught by @ttnghia in #1623

Originally posted by @ttnghia in #1623 (comment)

@razajafri razajafri self-assigned this Dec 15, 2023
@ttnghia
Copy link
Collaborator

ttnghia commented Dec 15, 2023

An alternative way is to enforce line length in our IntelliJ style: https://www.jetbrains.com/help/idea/code-style-sql-code.html#:~:text=To%20configure%20the%20line%20length,wrap%20at%20N%20columns%20field.

@razajafri
Copy link
Collaborator Author

An alternative way is to enforce line length in our IntelliJ style: https://www.jetbrains.com/help/idea/code-style-sql-code.html#:~:text=To%20configure%20the%20line%20length,wrap%20at%20N%20columns%20field.

Yes, but that won't work for people using vscode. We should do both like we do in the plugin

@razajafri razajafri changed the title Introduce Lint Checks Introduce Lint Checks for Checking Code Style Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants