Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌[FEA]: Improve deterministic inference UX #174

Open
nbren12 opened this issue Feb 4, 2024 · 1 comment
Open

馃殌[FEA]: Improve deterministic inference UX #174

nbren12 opened this issue Feb 4, 2024 · 1 comment
Labels
? - Needs Triage Need team to review and classify enhancement New feature or request

Comments

@nbren12
Copy link
Collaborator

nbren12 commented Feb 4, 2024

Is this a new feature, an improvement, or a change to existing functionality?

Improvement

How would you describe the priority of this feature request

Medium

Please provide a clear description of problem you would like to solve.

Basic deterministic inference with e2mip is rather difficult and non-intuitive for some users. I've seen multiple users give up on the tool because of it.

xarray does not support netCDF groups well, so it looks like the output data is empty when using xarray.open_dataset. The solution is to pass xarray.open_dataset(path, group="group").

Likewise, most users simply want to run a deterministic forecast with a few output fields. This is too difficult to do right now, and requires a configuration like this:

    config_dict = {
        "simulation_length": nt,
        "weather_event": {
            "properties": {
                "name": "Globe",
                "start_time": "2018-01-02 00:00:00",
                "initial_condition_source": "cds",
            },
            "domains": [
                {
                    "name": "global",
                    "type": "Window",
                    "diagnostics": [{"type": "raw", "channels": ["t2m", "z500"]}],
                }
            ],
        },
        "output_path": output_path,
        "weather_model": "this value is overrided",
        "output_frequency": 4,
    }

Perhaps we could a simple convenience function for deterministic forecasts:

def run_deterministic(time_loop, data_source,  length: datetime.timedelta, channels: list[str], output_path: str, frequency: datetime.timedelta):
    

Describe any alternatives you have considered

No response

@nbren12 nbren12 added enhancement New feature or request ? - Needs Triage Need team to review and classify labels Feb 4, 2024
@nbren12
Copy link
Collaborator Author

nbren12 commented Feb 4, 2024

Could just add these options to run_basic_inference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant