Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider swapping parameters less often in DPO #61

Open
odelalleau opened this issue Dec 18, 2023 · 0 comments
Open

Consider swapping parameters less often in DPO #61

odelalleau opened this issue Dec 18, 2023 · 0 comments

Comments

@odelalleau
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Currently, in DPO the swapping between parameters of the current vs. reference policies occurs after each batch, but this may be inefficient for large models => allowing less frequent swapping may be beneficial.

Describe the solution you'd like

  1. Profile code on Llama2-70B to estimate potential benefits of less frequent swapping
  2. If these benefits are not negligible: implement it

Additional context

The current implementation is already partially designed to support less frequent swapping. We just need to make sure this plays well with the optimization that pads each batch to a different length (either procesing each batch independently, or re-padding them to the same length)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant