New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code cleanup proposal #54

Open

gshennvm opened this issue Dec 9, 2023 · 0 comments

Collaborator

gshennvm commented Dec 9, 2023

currently we have a few code cleanness issues:

get_loss_and_metrics has a lot of duplicate code that can be written better
logic for inference broadcasting should be handled on the server side infer
DPO and PPO GPTModel can be one class with shared functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment