Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend SPIN to be able to handle the cast of rollout_MBS < DP_size #171

Open
trias702 opened this issue May 3, 2024 · 0 comments
Open

Amend SPIN to be able to handle the cast of rollout_MBS < DP_size #171

trias702 opened this issue May 3, 2024 · 0 comments

Comments

@trias702
Copy link
Collaborator

trias702 commented May 3, 2024

Since we added the generation rollout MBS parameter to SPIN for PR-133, we set it up in such a way that this new rollout MBS cannot be less that the DP size of your model training.

More details can be viewed here

We should now update SPIN to correctly handle the case of rollout MBS < DP size, and this can be done during the upcoming TRTLLM integration work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant