Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFT val_check_interval should accept float input #160

Open
AtsunoriFujita opened this issue Apr 18, 2024 · 0 comments
Open

SFT val_check_interval should accept float input #160

AtsunoriFujita opened this issue Apr 18, 2024 · 0 comments

Comments

@AtsunoriFujita
Copy link

AtsunoriFujita commented Apr 18, 2024 •
edited

Is your feature request related to a problem? Please describe.

Unlike NeMo, the NeMo-Aligner API ignores float inputs (fraction) to val_check_interval.
Fraction input is intuitive and should help improve UX.

Describe the solution you'd like

NeMo's implementation would be helpful. Dependencies will be looked into in the future.
@AtsunoriFujita AtsunoriFujita changed the title SFT limit_val_batches should accept float input on SFT SFT limit_val_batches should accept float input Apr 18, 2024
@AtsunoriFujita AtsunoriFujita changed the title SFT limit_val_batches should accept float input SFT val_check_interval should accept float input Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AtsunoriFujita