Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFT is broken with container 24.01.01 #131

Open
odelalleau opened this issue Mar 22, 2024 · 1 comment
Open

SFT is broken with container 24.01.01 #131

odelalleau opened this issue Mar 22, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@odelalleau
Copy link
Collaborator

Describe the bug

A user reported a crash with 24.01.01 and SFT (while things work fine with 24.01):

File "/opt/NeMo-Aligner/examples/nlp/gpt/train_gpt_sft.py", line 215, in main
    init_using_ptl(trainer, ptl_model, train_dataloader, train_ds)
  File "/opt/NeMo-Aligner/nemo_aligner/utils/train_script_utils.py", line 103, in init_using_ptl
    call._call_setup_hook(ptl_trainer)
  File "/usr/local/lib/python3.10/dist-packages/pytorch_lightning/trainer/call.py", line 86, in _call_setup_hook
    _call_lightning_module_hook(trainer, "setup", stage=fn)
  File "/usr/local/lib/python3.10/dist-packages/pytorch_lightning/trainer/call.py", line 145, in _call_lightning_module_hook
    output = fn(*args, **kwargs)
  File "/opt/NeMo/nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py", line 1372, in setup
    self._reconfigure_val_batches()
  File "/opt/NeMo/nemo/collections/nlp/models/language_modeling/megatron_base_model.py", line 340, in _reconfigure_val_batches
    val_len_in_micro_batches = len(self._validation_dl)
TypeError: object of type 'NoneType' has no len()
@odelalleau odelalleau added the bug Something isn't working label Mar 22, 2024
@AtsunoriFujita
Copy link

Thank you. I tested on 24.03 container and It has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants