Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Single quotes in organization name are not escaped properly #2560

Closed
dirkpetersen opened this issue May 6, 2024 · 2 comments · Fixed by #2581
Closed

[BUG] Single quotes in organization name are not escaped properly #2560

dirkpetersen opened this issue May 6, 2024 · 2 comments · Fixed by #2581
Assignees
Labels
bug Something isn't working

Comments

@dirkpetersen
Copy link

dirkpetersen commented May 6, 2024

An Org Admin registered with an organization name "Ben's Site". Unfortunately the single quote / apostrophe is not properly escaped and when I startup the client with /var/tmp/cloud/startup/start.sh I get this

PYTHONPATH is /local/custom:
/var/tmp/cloud/startup/sub_start.sh: line 82: unexpected EOF while looking for matching `"'
/var/tmp/cloud/startup/sub_start.sh: line 88: syntax error: unexpected end of file

The org name is not escaped and changing "Ben's" to "Ben\'s" did the trick

grep "Ben's" sub_start.sh
((python3 -u -m nvflare.private.fed.app.client.client_train -m $DIR/.. -s fed_client.json --set secure_train=true uid=AWS-T4 org=Ben's site config_folder=config 2>&1 & echo $! >&3 ) 3>$DIR/../pid.fl )
@dirkpetersen dirkpetersen added the bug Something isn't working label May 6, 2024
@YuanTingHsieh
Copy link
Collaborator

Thanks for raising this issue, @IsaacYangSLA can you check if we can support this scenario? thanks

@IsaacYangSLA
Copy link
Collaborator

Thanks for reporting the issue. The issue might be related to how to allow special characters in different places. As a quick fix, we can escape that in shell scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants