Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing documentation for calibration file #27

Open
nakai-omer opened this issue Jul 17, 2023 · 2 comments
Open

Missing documentation for calibration file #27

nakai-omer opened this issue Jul 17, 2023 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@nakai-omer
Copy link

Running this package for a mono camera we are getting the following error:

Failed to get calibration data from Argus!

We have followed this guide for creating a calibration file, and after doing all the steps we have a camera_info.yaml file, but there is no explanation what we are supposed to do with this file. This packages seems to expect an ini file. So the bridge between the yaml and ini is missing in the docs.

@nakai-omer
Copy link
Author

nakai-omer commented Jul 17, 2023

After al little more digging into the CameraInfoManager I saw that yaml files should also be supported. Nevertheless, trying to use the yaml file yielded the following error:

[component_container_mt-1] [INFO] [1689585165.778248505] [argus_mono]: camera calibration URL: package://isaac_ros_argus_camera/config/narrow_stereo.yaml
[component_container_mt-1] [WARN] [1689585165.782182253] [camera_calibration_parsers]: Exception parsing YAML camera calibration:
[component_container_mt-1] yaml-cpp: error at line 3, column 14: bad conversion
[component_container_mt-1] [ERROR] [1689585165.782326126] [camera_calibration_parsers]: Failed to parse camera calibration from file [/workspaces/isaac_ros-dev/install/isaac_ros_argus_camera/share/isaac_ros_argus_camera/config/narrow_stereo.yaml]

So I manually created an ini file from the yaml file, by structuring it like here. (UPDATE: the txt file created by the camera calibration pkg matches the ini file structure, so it can be used directly) Now the calibration file is being loaded as expected, but the following warning still exists:

amera.cpp@580: Failed to get calibration data from Argus!

I looked at the camera_info being published, and it matches the calibration info from the ini file.

@swapnesh-wani-nvidia swapnesh-wani-nvidia self-assigned this Jul 24, 2023
@swapnesh-wani-nvidia swapnesh-wani-nvidia added the documentation Improvements or additions to documentation label Jul 24, 2023
@swapnesh-wani-nvidia
Copy link

Thank you for this issue. We will make the documentation clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants