Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review saturation function implementation in GENR/GENS models #235

Open
jd-lara opened this issue May 23, 2022 · 0 comments
Open

review saturation function implementation in GENR/GENS models #235

jd-lara opened this issue May 23, 2022 · 0 comments

Comments

@jd-lara
Copy link
Member

jd-lara commented May 23, 2022

The current implementation of the saturation always calculates the total field ψ_pp = sqrt(ψd_pp^2 + ψq_pp^2) and later passes the value through the function. This adds an unnecessary calculation if the saturation parameters are 0.0.

Implement a saturation function that takes the values of ψd_pp and ψq_pp directly.
@jd-lara jd-lara self-assigned this May 23, 2022
@jd-lara jd-lara removed their assignment Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jd-lara