Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Pass through meta from msg #511

Open
lougreenwood opened this issue Dec 27, 2022 · 2 comments
Open

[Feature]: Pass through meta from msg #511

lougreenwood opened this issue Dec 27, 2022 · 2 comments
Assignees
Labels
enhancement 👍 New feature or request

Comments

@lougreenwood
Copy link

lougreenwood commented Dec 27, 2022

Your Current NRCHKB Plugin Version

1.5.0

Operating System

No response

What is your idea?

When a NK service node is triggered, it should be possible to pass additional metadata through the service node and receive that metadata on the output.

For example, if I pass the following data to a switch, I would expect the following output:

Service node input

msg: {
  payload: {
    On: true
  },
  meta: {
    someMetaValue: 123,
  }
}

Service node output

msg: {
  payload: {
    On: true
  },
  hap: { ... },
  name: 'device name',
  meta: {
    someMetaValue: 123,
  }
}

I already have message passthrough enabled, but it seems that a service node builds a completely new message and disregards almost all values passed to it's input.

Any more details?

If this is specific to some hardware or specific software version, please explain here.

Additional comments?

Additional comments here, if any.

Any code or functions to add?

No response

@lougreenwood lougreenwood added the enhancement 👍 New feature or request label Dec 27, 2022
@lougreenwood lougreenwood changed the title [Feature]: Pass through properties from msg [Feature]: Pass through meta from msg Dec 27, 2022
@deancs
Copy link

deancs commented Jun 24, 2023

+1 for this request. Thanks for a great addition to NR. Its pretty much a NR convention that msg objects are passed-through with the node only making the specified changes based on its function.

@Shaquu
Copy link
Member

Shaquu commented Jul 2, 2023

+1 for this request. Thanks for a great addition to NR. Its pretty much a NR convention that msg objects are passed-through with the node only making the specified changes based on its function.

Noted :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 👍 New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants