Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: wait for setup devices forget devices that are published late #482

Open
sjorge opened this issue Apr 16, 2022 · 2 comments
Open

[Bug]: wait for setup devices forget devices that are published late #482

sjorge opened this issue Apr 16, 2022 · 2 comments
Assignees
Labels
bug 🐛 There is at least high chance that it is a bug!

Comments

@sjorge
Copy link

sjorge commented Apr 16, 2022

NRCHKB Plugin Version

1.5.0-dev.2

Node JS Version

v16.14.2

NPM Version

8.5.0

Node-RED Version

2.1.3

Operating System

OmniOS

What happened?

All my devices have wait for setup, sometimes one of my devices would appear as a new device for homekit.

It took a while to track down while, occasionally one or two devices would get there setup payload published a bit later than the others. This device still shows up but it looks like some of the 'remembered' information about the device in that case gets discarded and new UUID and such are generated for the devices that get published a bit later.

This is rather annoying as it only happens every so often and it's very hard to trigger in my actual setup.

Doing it manually is easy as you can just insert a delay node for example for 10 seconds on one service and that would trigger it.

How to reproduce?

  • setup 2 services with wait for setup
  • publish a payload to them via a inject node (once at startup)
  • add a delay node, say 10 sec or more to one of the two.

Expected behavior:

Even if a service gets the setup message a bit later than the other, it should still retain UUID's so it appears as the same device to homekit.

Additional comments?

Additional comments here, if any.

Relevant log output

No response

@sjorge sjorge added the bug 🐛 There is at least high chance that it is a bug! label Apr 16, 2022
@caitken-com
Copy link

caitken-com commented Aug 15, 2023

Hi @sjorge, is this resolved?

  1. Have you set NR to only deploy modified nodes only?

@sjorge
Copy link
Author

sjorge commented Aug 15, 2023

No, mine is set to do full deploys.

it’s still not resolved, the problem is not the node deployment but that when a setup payload is received later for a node it misses the boat so to speak and falls into the water.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 There is at least high chance that it is a bug!
Projects
None yet
Development

No branches or pull requests

3 participants