Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ngen shows a NetCDF file closing error after finishing the run when using NetCDF forcing file #818

Closed
stcui007 opened this issue May 9, 2024 · 2 comments · Fixed by #819
Labels
bug Something isn't working

Comments

@stcui007
Copy link
Contributor

stcui007 commented May 9, 2024

This issue is created after today's discussion at the daily stand up. We agreed that there was a need to refresh people's mind about Issue 749, where there were some discussions and details about the issue already. The main point is that we need in our ngen code to close/destruct/cleanup all our files/objects before finishing.

#749

As a reference, there is a rudimentary version that seems to fix the issue: https://github.com/stcui007/ngen/tree/I481_netcdf. Maybe a better design is needed.

Current behavior

Expected behavior

Steps to replicate behavior (include URLs)

Screenshots

@stcui007 stcui007 added the bug Something isn't working label May 9, 2024
@PhilMiller
Copy link
Contributor

Duplicate of the earlier linked issue

@stcui007
Copy link
Contributor Author

stcui007 commented May 30, 2024 via email

@PhilMiller PhilMiller linked a pull request May 30, 2024 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants