Refactor DataProvider::get_values interface and implementations to avoid excess allocation and copying

[PhilMiller]

ngen/include/forcing/DataProvider.hpp

Line 87 in dd66466

virtual std::vector<data_type> get_values(const selection_type& selector, ReSampleMethod m=SUM) = 0;

The member function signature in the DataProvider interface demands the allocation of a temporary vector and the likely copying of data from that temporary vector by the consumer.

The signature ought to be

virtual void get_values(boost::span<data_type> output, selection_type const&  selector, ReSampleMethod = SUM);

We could phase the refactoring by

• adding this as an overload to the interface, with a default implementation that just calls the existing get_values and copies the data
• Implement for various DataProvider implementations
• Exploit in DataProvider::get_values callers