Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Forcing Engine CI/CD Job and Realization Config Option #764

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Add Forcing Engine CI/CD Job and Realization Config Option #764

wants to merge 4 commits into from

Conversation

program--
Copy link
Contributor

This PR resolves #762 and resolves #763.

Additions

  • Adds test_forcing_engine_integration to module integrations. This job runs the test_forcings_engine unit test executable.
  • Adds a branch in Formulation_Constructors for a ForcingEngine option. Currently, this throws a runtime error.

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Target Environment support

  • Linux
  • macOS

@program-- program-- added the enhancement New feature or request label Mar 13, 2024
@program-- program-- self-assigned this Mar 13, 2024
PhilMiller
PhilMiller reviewed May 10, 2024
View reviewed changes
.github/workflows/module_integration.yml
popd
rm -r /tmp/esmf

# TODO: Store in Git or Pull? They are large files
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Git-LFS could be good for this.
https://docs.github.com/en/repositories/working-with-files/managing-large-files/about-git-large-file-storage

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or, we could do the testing with very cut-down files that will fit in the repo more nicely.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah those are the same two options I was considering -- I'm leaning toward creating cut down files and creating a simple domain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilMiller PhilMiller PhilMiller left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@program-- program--

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CI/CD for Forcings Engine Add Forcings Engine as option in Realization Config
2 participants
@program-- @PhilMiller