Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#737: Initial draft of SCHISM Coastal Formulation #810

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

#737: Initial draft of SCHISM Coastal Formulation #810

wants to merge 1 commit into from

Conversation

PhilMiller
Copy link
Contributor

@PhilMiller PhilMiller commented May 3, 2024 •
edited

Resolves #737

Additions

  • CoastalFormulation abstract base class
  • Support classes for relevant DataProvider instantiations that CoastalFormulation will need
  • SCHISM-based implementation of CoastalFormulation

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

  • Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement 'coastal realization' formulation
1 participant
@PhilMiller