Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GIUH and Nash-Cascade to external #80

Open
SnowHydrology opened this issue Mar 13, 2023 · 0 comments
Open

Move GIUH and Nash-Cascade to external #80

SnowHydrology opened this issue Mar 13, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@SnowHydrology
Copy link
Contributor

CFE uses the geomorphic instantaneous unit hydrograph (GIUH) and Nash-Cascade model to route surface and subsurface runoff, respectively. Other models implemented for NextGen will likely use these routines as well.

Current behavior

GIUH and Nash-Cascade code are part of the CFE repo and will have to be ported to other models.

Expected behavior

GIUH and Nash-Cascade code should be moved to their own standalone repos or a NextGen utilities repo. This way each model formulation that requires them, including CFE, can import the code as a GitHub external submodule. This will prevent us from having to maintain duplicate code in multiple locations. (To note: we have fixed this same-code-multiple-locations issue with AORC forcing and PET recently.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants