Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exposing nash cascade storages to BMI for purposes of checkpointing/hotstarting #74

Open
fred-ogden opened this issue Jan 17, 2023 · 1 comment

Comments

@fred-ogden
Copy link

Short description explaining the high-level reason for the new issue.

Current behavior

Nash cascade number and storages are not exposed through the BMI. Item identified by Dan Wright.

Expected behavior

For purposes of checkpointing/hotstarting, the number of Nash linear reservoirs in the cascade and the storage in each reservoir are required.

Steps to replicate behavior (include URLs)

Screenshots

@SnowHydrology
Copy link
Contributor

@fred-ogden, @peckhams and @madMatchstick can give more details, but the full list of model variables is exposed via BMI in the owp-bmi-enhance branch. See the source code for bmi_cfe.c here, for example: https://github.com/NOAA-OWP/cfe/blob/owp-bmi-enhance/src/bmi_cfe.c

To perform checkpointing and hotstarting I believe we'll need more variables past the nash cascades that aren't currently available via BMI. We should start considering whether we'll want to use the serialization work that Scott and Jess have researched and performed, or find a way using BMI 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants