Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect unit for RAIN_RATE ouput #58

Open
lcunha0118 opened this issue Apr 7, 2022 · 0 comments
Open

Incorrect unit for RAIN_RATE ouput #58

lcunha0118 opened this issue Apr 7, 2022 · 0 comments

Comments

@lcunha0118
Copy link
Contributor

The output defined as RAIN_RATE in output_var_names has unit of m ( see [https://github.com/NOAA-OWP/cfe/blob/39c18a100dcb5c664900711c8f65f786642f0671/src/bmi_cfe.c#L203]) according to the bmi functions, but the output actually is in mm.

Current behavior

Incorrect unit (mm) for RAIN_RATE output.

Expected behavior

RAIN_RATE in m

Suggested fix:

Since all other variables are in m, we probably want to keep this variable in m, and convert the variable from mm to m within the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant