Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DataFormat values and domain detectors to account for hydrofabric contextual restriction #605

Open
robertbartel opened this issue May 7, 2024 · 1 comment
Labels
enhancement New feature or request maas MaaS Workstream

Comments

@robertbartel
Copy link
Contributor

For a large portion of all possible DMOD datasets, the data and metadata only become fully meaningful in the context of a particular hydrofabric dataset that establishes the spatial domain. For example, without an associated hydrofabric, an AORC forcing CSV file for catchment cat-112 contains data applicable only to some abstract conceptual region. It cannot be determined whether the data is accurate (i.e., was the regridding correct for cat-112) or valid (i.e., is there a cat-112) outside of the context of a hydrofabric.

The dataset modeling of DMOD, including the data formats, data domains, and data domain detectors, does not fully account for the relationship between these datasets and a hydrofabric dataset. This needs to be corrected.

@aaraney
Copy link
Member

aaraney commented May 13, 2024

This is a great point, @robertbartel. We should talk to the HF team about what assumptions we can make about certain metadata fields in a HF. For example, can we rely on cat-112 as a name without other context (i.e. the HF version, implying that the cat number can change version to version). I think understanding their domain and data model will be really helpful to this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maas MaaS Workstream
Projects
None yet
Development

No branches or pull requests

2 participants