Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only expose an opaque pointer for the different plans in the public API #10

Open
jenskeiner opened this issue Mar 9, 2016 · 0 comments
Assignees
Milestone

Comments

@jenskeiner
Copy link
Contributor

Transferred from: https://github.com/NFFT/nfft_old/issues/5

Right now, the public API exposes the whole plan structure, which increases the potential for API breakage in future updates. This is what happened when the _flags attribute has been renamed to just flags in a previous commit for instance.

In order to avoid that later, but also simplify the public API a bit, it would be better to only expose all plans as opaque pointers and hide the internal structure of each plan to the user, as it is done in FFTW actually.

The flipside of this change is that the x, f and f_hat can no longer be accessed directly and should be updated through the public APIs functions and / or assigned during initialization. I feel confident I can come up with a design for that following what is done in FFTW, but I wanted to discuss that here first.

@jenskeiner jenskeiner self-assigned this Mar 9, 2016
@jenskeiner jenskeiner added this to the 4.0.0 milestone Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants
@jenskeiner and others