Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting issues with hierarchical roofline #90

Open
jrmadsen opened this issue Oct 20, 2020 · 6 comments
Open

Plotting issues with hierarchical roofline #90

jrmadsen opened this issue Oct 20, 2020 · 6 comments
Assignees

Comments

@jrmadsen
Copy link
Collaborator

Using output ert_results.json, only one memory level is plotted:

python -m timemory.roofline -d -ai ert_results.json -op ert_results.json
@jrmadsen
Copy link
Collaborator Author

ert_results.json can be generated from ex_ert with -DTIMEMORY_BUILD_EXAMPLES=ON

@jrmadsen
Copy link
Collaborator Author

ert_results

ert_results.json.zip

@jrmadsen
Copy link
Collaborator Author

Requires changes in #89, specifically:

if self.units is not None:

        if self.units is not None:
            for i in range(len(self.data)):
                self.data[i] /= self.units

@PointKernel
Copy link
Contributor

OK, actually that's the issue I was referring to: the L1 and L2 data may be there in the .json file, but the numbers are wrong cause ERT cannot properly measure the L1 bandwidth on modern architectures such as Skylake or V100 or even P100. I will definitely look into this issue since it's been there for a long time already. Will keep you updated here.

@jrmadsen
Copy link
Collaborator Author

jrmadsen commented Dec 6, 2020

Would it help to have the L1, L2, and (if exists) L3 data cache sizes in the JSON so you can extract the ERT tests around those values?

@PointKernel
Copy link
Contributor

That will definitely help the L2 and L3 detection, the major issue is that ERT can never reach the L1 bandwidth on either Skylake or P100/V100. I need to try some new kernels (micro-benchmarks) on ERT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants