New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support creation of unlimited graph types #268
Comments
Thanks @gothub . This is great. I think we could tweak a few details to improve it. Here's a few questions and comments:
That is a more RESTful pattern, where the suite is treated as a collection, the data collection comes second, and the product type is the resource that's available for that collection. It also unifies the graph and csv retrieval to get rid of the difficult Accept header, and opens the door to new product types that are neither graphs nor csv files, like PDFs. I'd like to get feedback from @csjx and others on this as well. Let's discuss. |
@mbjones thx for the review - here are some thoughts on the points you raised:
|
@mbjones @csjx when would be a good time to discuss/enumerate the range of products that need to be generated and retrievable, and how that is represented in the API. The current potential list of product types:
Each of these products can be generated for or filtered by the following: |
@mbjones here are proposed changes to the quality engine to support generation/retrieval of any number of assessment graph types for a set of data (portal, member node, all of DataONE).
The quality engine should allow the creation of any number of graphs for a set of metadata. For example, for the metadata associated with a DataONE portal (i.e the collectionQuery pids), any number of different assessment graphs should be created and available when this portal is updated. The current list of desired graphs are "monthly", "cumulative", "check-analysis", but there could be many more.
The current REST endpoints to create and retrieve a graph for a portal is shown here with an example curl command:
Note that the 'id' currently can either be a portal series id (urn:uuid:*) or a node id (e.g. urn:node:CA_OPC).
The quality engine and API should be extended to support these additional parameters for retrieval:
The request to generate data and a graph should not include the type of graph to create, as all known graph types and variations should be created and made available for retrieval, based on only the id and suite.
The scripts that generate each graph type could follow a naming convention, so that the quality engine could automatically run them when they are added to the quality engine.
The text was updated successfully, but these errors were encountered: