Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand war files before or in Docker Build #1785

Open
artntek opened this issue Jan 23, 2024 · 0 comments
Open

Expand war files before or in Docker Build #1785

artntek opened this issue Jan 23, 2024 · 0 comments
Milestone

Comments

@artntek
Copy link
Contributor

artntek commented Jan 23, 2024

A good discussion with @vchendrix helped me understand that it's better to have the metacat war file already exploded as part of the docker build (or the build.sh stage before that), instead of doing it in the entrypoint script.

This then allows the use of configMaps in the helm chart, to override the configuration directly, instead of doing search-and-replace in files etc. (For example, some of the replacement stuff we do in docker-entrypoint.sh)

@artntek artntek added this to the 3.1.0 milestone Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant