Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix flakiness of some precision-based testing #679

Open
sadielbartholomew opened this issue Jun 30, 2023 · 0 comments
Open

CI: fix flakiness of some precision-based testing #679

sadielbartholomew opened this issue Jun 30, 2023 · 0 comments
Assignees
Labels
CI GitHub Actions Anything relating to GitHub actions testing Issues related to units tests and their coverage

Comments

@sadielbartholomew
Copy link
Member

Some tests which pass locally fail on some (and possibly all in some cases) of the CI job runs corresponding to the full test suite running workflow. They therefore seem to be 'flaky' tests.

Most if not all of these tests involve precision equality testing, for example isclose with given atol and rtol and therefore floating point rounding or tolerance variations are likely the reason for the variation in result on different environments.

See also the following comments, for further context:

@sadielbartholomew sadielbartholomew added CI testing Issues related to units tests and their coverage GitHub Actions Anything relating to GitHub actions labels Jun 30, 2023
@sadielbartholomew sadielbartholomew self-assigned this Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI GitHub Actions Anything relating to GitHub actions testing Issues related to units tests and their coverage
Projects
None yet
Development

No branches or pull requests

1 participant