Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check to disallow usage of horizontal_dimension in the run phase #521

Open
peverwhee opened this issue Jan 3, 2024 · 0 comments
Open
Labels

Comments

@peverwhee
Copy link
Collaborator

Description

There is currently no check that disallows usage of horizontal_dimension in the run phase of a physics scheme (where horizontal_loop_extent must be used).

Steps to Reproduce

  1. Check out the head of feature/capgen
  2. Attempt to run with a physics scheme (or modify an existing test scheme) that uses horizontal_dimension in the run phase in the metadata
  3. See that it compiles without error.

Additional Context

The framework will currently error if you try to use horizontal_loop_extent outside of the run phase, so it should be updated to error when you try to misuse horizontal_dimension as well.

@peverwhee peverwhee added the bug label Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant