Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions: Add Structural Metadata #554

Merged
merged 43 commits into from
May 25, 2024
Merged

Extensions: Add Structural Metadata #554

merged 43 commits into from
May 25, 2024

Conversation

gkjohnson
Copy link
Contributor

@gkjohnson gkjohnson commented May 11, 2024

Fix #527

TODO

  • Test with all data
  • Handle node and primitive references
  • Reference all schemas
  • Add helpers for properties that take class and property references and provide a function for reading the data
  • Add demo with hover states, displaying table info

Next

  • Add d.ts files
  • Add simpler ability to get structural metadata from the features
  • Add highlighting based on StructuralMetada fields + feature ids?

Questions

  • Is it the case that all textures are guaranteed to be uint8 type?
  • Recommendations on handling BigInt?
  • Are property tables usable without node property and / or mesh features?
  • Are attribute accessors usable without non point objects?
  • What are the usable cases when an internal node does and doesn't contain an extension reference?

@gkjohnson gkjohnson added this to the v0.3.32 milestone May 11, 2024
@gkjohnson gkjohnson modified the milestones: v0.3.32, v0.3.33 May 14, 2024
@gkjohnson gkjohnson marked this pull request as ready for review May 25, 2024 13:50
@gkjohnson gkjohnson merged commit 83e912c into master May 25, 2024
2 checks passed
@gkjohnson gkjohnson deleted the structural-metadata branch May 26, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for EXT_structural_metadata extension
1 participant