Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add get_selection() to MycroftSkill class #2276

Closed
krisgesling opened this issue Aug 29, 2019 · 5 comments
Closed

Feature: Add get_selection() to MycroftSkill class #2276

krisgesling opened this issue Aug 29, 2019 · 5 comments
Labels
Difficulty: medium help wanted Type: Enhancement - proposed New proposal for a feature that is not currently a priority on the roadmap.

Comments

@krisgesling
Copy link
Contributor

A common need for Skill developers is to present a list of options to the user and ask them to make a selection. This is possible using a combination of existing methods, however it requires each developer to work out their own pattern. Adding a standard method will make this easier for developers and provide a more consistent experience for users.

The current method generally involves:

  1. Take list of items
  2. Generate question dialog using join_list()
  3. get_response() from user
  4. validate response checking for:
    • fuzzy match of list item
    • ordinal or number eg "third item", or "number two"
  5. return selected item, or execute on_fail callback
@krisgesling krisgesling added Type: Enhancement - proposed New proposal for a feature that is not currently a priority on the roadmap. help wanted Difficulty: medium labels Aug 29, 2019
@arjangupta
Copy link

Hi, I'm interested in this issue. Has anyone claimed it yet?

@forslund
Copy link
Collaborator

Not as far as I've heard, go for it!

If you have questions we have a chat at chat.mycroft.ai

@krisgesling
Copy link
Contributor Author

Please do, thanks Arjan 😄

@ChanceNCounter
Copy link
Contributor

Closed by #2302, no?

@forslund
Copy link
Collaborator

You are quite correct. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty: medium help wanted Type: Enhancement - proposed New proposal for a feature that is not currently a priority on the roadmap.
Projects
None yet
Development

No branches or pull requests

4 participants