Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the requirement of double-encoded json messages #1291

Open
supertick opened this issue May 28, 2023 · 1 comment
Open

Remove the requirement of double-encoded json messages #1291

supertick opened this issue May 28, 2023 · 1 comment

Comments

@supertick
Copy link
Contributor

Describe the bug
parameters currently are double encoded within a json message definition
Remove and fix external clients ...

@AutonomicPerfectionist
Copy link
Contributor

I think double encoding is fine, personally. Sometimes we do need the information from the message itself in order to deserialize the data parameters, even with the embedded class field. An example is given in #1289 actually, it uses the destination name of the message to lookup the expected data type to deserialize into, which strengthens type safety and wouldn't be easy to do without double encoding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants