Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

MvxPagePresentationHint does not work on ios when the view being navigated to is inside a navigation controller #4405

Open
1 of 7 tasks
calebwilson706 opened this issue May 11, 2022 · 3 comments

Comments

@calebwilson706
Copy link

calebwilson706 commented May 11, 2022

馃悰 Bug Report

When i use a MvxPagePresentationHint to navigate to a view in which is wrapped in a navigation controller it does not navigate to the tab for this view model

Expected behavior

It should navigate to the view model passed in with the presentation hint.

Reproduction steps

1.) Create a view controller which is wrapped in a navigation controller using the MvxTabPresentationAttribute
2.) try to navigate to this view using ChangePresentation(new MvxPagePresentationHint(YourViewModelType))

Configuration

Version: 8.0.2

Platform:

  • 馃摫 iOS
  • 馃 Android
  • 馃弫 WPF
  • 馃寧 UWP
  • 馃崕 MacOS
  • 馃摵 tvOS
  • 馃悞 Xamarin.Forms
@calebwilson706
Copy link
Author

calebwilson706 commented May 11, 2022

from debugging i have found that inside ChangePagePresentation that GetViewModelType is returning IMxvViewModel for my view controller instead of my bespoke view model type

@calebwilson706
Copy link
Author

However it isn't doing this for all my view controllers wrapped inside a navigation controller, it is only one of them

@calebwilson706
Copy link
Author

Im seeing now that the ViewModel property for my view controller that i'm looking to navigate too is null and hence why it is not finding the right type. Any suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant