Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-static inner classes, do they pose an issue? #35

Open
neomatrix369 opened this issue Dec 31, 2012 · 0 comments
Open

Non-static inner classes, do they pose an issue? #35

neomatrix369 opened this issue Dec 31, 2012 · 0 comments
Assignees
Labels

Comments

@neomatrix369
Copy link
Member

After fixing issue #33, a discussion about non-static inner classes lead to the below inquiry, @Grundlefleck recommended investigating further:

In terms of inner classes, static inner classes are no issue at all. They do not have a reference to the enclosing class so state changed does not affect the outer class. Non-static inner classes may be an issue, and worth investigating more, but I don't think it should hold up this issue, as I suspect the builder pattern would be more common for immutable classes. Worth a look though, if you're interested.

If the outcome of the investigation helps prove that the initial theory was correct about non-static classes being a problem, it will be considered an issue for further investigation and fixing.

@ghost ghost assigned neomatrix369 Dec 31, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant