Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not figure out read 2 length from RunInfo.xml #2508

Closed
nick-youngblut opened this issue Apr 26, 2024 · 5 comments
Closed

Could not figure out read 2 length from RunInfo.xml #2508

nick-youngblut opened this issue Apr 26, 2024 · 5 comments
Labels
bug: module Bug in a MultiQC module waiting: example data Needs example data before we can proceed

Comments

@nick-youngblut
Copy link

Description of bug

Running MultiQC on bcl-convert output.

The error:

    /// MultiQC 馃攳 | v1.21

  |           multiqc | Search path : /home/nickyoungblut/tmp/auto-demux/work/20240424_SspArc0134/98/59d4ff8cb59bcad571ae8e5cb0cad5
  |         searching | 鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣 100% 12/12
  |        bclconvert | Could not figure out read 2 length from RunInfo.xml
  |           multiqc | No analysis results found. Cleaning up..
  |           multiqc | MultiQC complete

The top of the RunInfo.xml file:

<?xml version="1.0"?>
<RunInfo Version="6">
	<Run Id="240425_VH00848_69_AACGH3VHV" Number="69">
		<Flowcell>AACGH3VHV</Flowcell>
		<Instrument>VH00848</Instrument>
		<Date>2024-04-25T00:14:06Z</Date>
		<Reads>
			<Read Number="1" NumCycles="100" IsIndexedRead="N" IsReverseComplement="N"/>
			<Read Number="2" NumCycles="22" IsIndexedRead="N" IsReverseComplement="N"/>
		</Reads>
		<FlowcellLayout LaneCount="2" SurfaceCount="2" SwathCount="6" TileCount="14">
			<TileSet TileNamingConvention="FourDigit">
				<Tiles>
					<Tile>1_1101</Tile>
					<Tile>1_1102</Tile>
					<Tile>1_1103</Tile>

The RunInfo.xml file clearly shows the read 2 length, so it appears that MultiQC has a bug, or at least is generating a misleading error message.

File that triggers the error

No response

MultiQC Error log

`multiqc -f -n multiqc_report.html -o . .`


    /// MultiQC 馃攳 | v1.21

  |           multiqc | Search path : /home/nickyoungblut/tmp/auto-demux/work/20240424_SspArc0134/98/59d4ff8cb59bcad571ae8e5cb0cad5
  |         searching | 鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣 100% 12/12
  |        bclconvert | Could not figure out read 2 length from RunInfo.xml
  |           multiqc | No analysis results found. Cleaning up..
  |           multiqc | MultiQC complete


### Before submitting

- [X] I have read the [troubleshooting documentation](https://multiqc.info/docs/usage/troubleshooting/).
- [X] I am using the latest release of MultiQC.
- [X] I have included a full MultiQC log, not truncated.
- [X] I have attached an input file (**.zip** if necessary) that triggers the error.
@nick-youngblut
Copy link
Author

nick-youngblut commented Apr 26, 2024

It appears that the bcl-convert module of MultiQC is making the assumption that there is a Number="3" or Number="4" <Read/> entry in the <Reads> block (the code).

As shown above, the RunInfo.xml for this NextSeq2k run simply includes <Read Number="1"/> and <Read Number="2"/>.

@vladsavelyev
Copy link
Member

vladsavelyev commented Apr 27, 2024

Thanks a lot for the bug report @nick-youngblut!

This should fix it: #2511 (and potentially other bugs related to uncommon combination of index and non-index reads).

Before I merge, can you please add your test example to https://github.com/MultiQC/test-data to make sure the fix works?

@vladsavelyev vladsavelyev added the bug: module Bug in a MultiQC module label Apr 27, 2024
@vladsavelyev vladsavelyev added this to the MultiQC v1.22: Pydantic milestone Apr 27, 2024
@vladsavelyev vladsavelyev added the waiting: example data Needs example data before we can proceed label Apr 27, 2024
@nick-youngblut
Copy link
Author

Before I merge, can you please add your test example to https://github.com/MultiQC/test-data to make sure the fix works?

I'm not sure where to put the file or how to name it. Should it go in https://github.com/MultiQC/test-data/tree/main/data/modules/bclconvert/3.9.3?

The RunInfo.xml file is simply:

<?xml version="1.0"?>
<RunInfo xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" Version="2">
  <Run Id="240426_M08192_0060_000000000-LDGFF" Number="60">
    <Flowcell>000000000-LDGFF</Flowcell>
    <Instrument>M08192</Instrument>
    <Date>240426</Date>
    <Reads>
      <Read NumCycles="514" Number="1" IsIndexedRead="N" />
      <Read NumCycles="86" Number="2" IsIndexedRead="N" />
    </Reads>
    <FlowcellLayout LaneCount="1" SurfaceCount="2" SwathCount="1" TileCount="19" />
  </Run>
</RunInfo>

...or any other RunInfo.xml file that just includes:

    <Reads>
      <Read NumCycles="XXX" Number="1" IsIndexedRead="N" />
      <Read NumCycles="XXX" Number="2" IsIndexedRead="N" />
    </Reads>

...will result in the same MultiQC error:

/// MultiQC 馃攳 | v1.21

|           multiqc | Search path : /home/nickyoungblut/tmp/auto-demux/work/20240426_SspArc0132/ea/6004aadcfc537522af64ea0646fcf0
|         searching | 鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣 100% 12/12
|        bclconvert | Could not figure out read 2 length from RunInfo.xml
|           multiqc | No analysis results found. Cleaning up..
|           multiqc | MultiQC complete

@vladsavelyev
Copy link
Member

vladsavelyev commented Apr 29, 2024

The location doesn't matter, you can even attach them here to a comment.

I really just wanted to test on a real life output with this set up, to see if other files would break as well (e.g. Quality_Metrics.csv, Adapter_Metrics.csv). Plus, the module wouldn't run at all without Demultiplex_Stats.csv.

Also, not relevant for Xml, but generally it's better to attach files as is, rather than copy the contents into a comment, because GitHub messes with spacing, and for many file types the concrete form of indentation matters.

@nick-youngblut
Copy link
Author

@vladsavelyev any idea when the new release of MultiQC will be published? I am using the MultiQC biocontainer for my Nextflow pipeline, and I'd rather use the biocontainer versus creating a custom Docker container with the most recent version of MultiQC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: module Bug in a MultiQC module waiting: example data Needs example data before we can proceed
Projects
None yet
Development

No branches or pull requests

2 participants