Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylize "Percentages" and "Log10" buttons as toggles #2417

Open
4 tasks done
tamuanand opened this issue Mar 2, 2024 · 4 comments
Open
4 tasks done

Stylize "Percentages" and "Log10" buttons as toggles #2417

tamuanand opened this issue Mar 2, 2024 · 4 comments

Comments

@tamuanand
Copy link

Description of bug

Hi @ewels and @vladsavelyev

I am not sure if this is a bug or a question - I thought I will put it in the bug category so that it gets looked into asap :)

  • I could not find any info on this below in the 1.20 or 1.21 release notes

With 1.21 and 1.20, some of the Picard related tabs within plots are missing when compared to 1.19

1.21 related images (same with 1.20)

image

image

1.19 related images
image

image

File that triggers the error

IMO - Not needed for this - but would be happy to provide

MultiQC Error log

docker run -t -v `pwd`:`pwd` -w `pwd` quay.io/biocontainers/multiqc:1.21--pyhdfd78af_0 multiqc . 
|         searching | ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 11/11
|            picard | Found 2 AlignmentSummaryMetrics reports
|            picard | Found 2 MarkDuplicates reports
|            picard | Found 2 RnaSeqMetrics reports
|             fastp | Found 2 reports
|           multiqc | Report      : multiqc_report.html
|           multiqc | Data        : multiqc_data   
|           multiqc | Plots       : multiqc_plots  
|           multiqc | MultiQC complete

Before submitting

  • I have read the troubleshooting documentation.
  • I am using the latest release of MultiQC.
  • I have included a full MultiQC log, not truncated.
  • I have attached an input file (.zip if necessary) that triggers the error.
@tamuanand
Copy link
Author

tamuanand commented Mar 3, 2024

Hi @ewels and @vladsavelyev

I will close this issue and post it at the community forum

This is the issue with 1.21 and 1.20

  • the percentages button is a toggle button (in Picard Mark Duplicates, fastp etc)
  • upon clicking the button, the plot below changes to show counts or number of reads - but the button name remains the same.

It would be great if the button name can dynamically change - _ a la _ how it changes in the General Stats table -

  • when you click "Violin Plot" the button changes to "table"

Without the button name change, it is going to catch lot of people unawares.

Thanks

@tamuanand tamuanand reopened this Mar 7, 2024
@tamuanand
Copy link
Author

@vladsavelyev
Copy link
Member

The "Percentage" button works like a toggle now. It has to states: pressed and unpressed. Perhaps need to stylize it accordingly to indicate how it works more clearly.

@vladsavelyev vladsavelyev changed the title Missing tabs for Picard related plots in 1.20 and 1.21 compared to 1.19 Stylize "Percentages" and "Log10" buttons as toggles Mar 7, 2024
@vladsavelyev vladsavelyev added this to the MultiQC v1.22: Pydantic milestone Mar 7, 2024
@tamuanand
Copy link
Author

IMHO, it might be best to have it similar to how you have the "Violin Plot" button

This behavior - "percentages button" is across many tools (like fastp) even though I only reported for Picard in this issue tracker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants